draft csi driver lvm extension #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit
…-driver-lvm into draft-csi-driver-lvm-extension
Gerrit91
reviewed
Nov 12, 2024
ostempel
force-pushed
the
draft-csi-driver-lvm-extension
branch
from
20dfc5a to
dd51c25
Compare
ostempel
force-pushed
the
draft-csi-driver-lvm-extension
branch
from
708c396 to
7cc4401
Compare
ostempel
force-pushed
the
draft-csi-driver-lvm-extension
branch
from
c1c3fab to
8f8b40d
Compare
ostempel
force-pushed
the
draft-csi-driver-lvm-extension
branch
from
14f738c to
5bf755a
Compare
Gerrit91
reviewed
Nov 22, 2024
charts/gardener-extension-csi-driver-lvm/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/gardener-extension-csi-driver-lvm/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/gardener-extension-csi-driver-lvm/templates/poddisruptionbudget.yaml
Outdated
Show resolved
Hide resolved
ostempel
force-pushed
the
draft-csi-driver-lvm-extension
branch
from
81d92cc to
cbfddd7
Compare
Gerrit91
reviewed
Dec 13, 2024
Gerrit91
reviewed
Dec 13, 2024
Co-authored-by: Gerrit <[email protected]>
Co-authored-by: Gerrit <[email protected]>
Gerrit91
reviewed
Dec 13, 2024
Gerrit91
reviewed
Dec 13, 2024
| return err | ||
| } | ||
|
|
||
| log.Info("managed resource created succesfully", "name", v1alpha1.ShootCsiDriverLvmResourceName) |
There was a problem hiding this comment.
Suggested change
| log.Info("managed resource created succesfully", "name", v1alpha1.ShootCsiDriverLvmResourceName) | |
| log.Info("managed resource created successfully", "name", v1alpha1.ShootCsiDriverLvmResourceName) |
…ck/gardener-extenstion-csi-driver-lvm into draft-csi-driver-lvm-extension
Gerrit91
reviewed
Dec 13, 2024
Co-authored-by: Gerrit <[email protected]>
Co-authored-by: Gerrit <[email protected]>
Gerrit91
reviewed
Dec 13, 2024
Comment on lines
+27
to
+28
| // var log = runtimelog.Log.WithName("gardener-extension-csi-driver-lvm") | ||
|
|
There was a problem hiding this comment.
Suggested change
| // var log = runtimelog.Log.WithName("gardener-extension-csi-driver-lvm") |
Gerrit91
reviewed
Dec 13, 2024
…ck/gardener-extenstion-csi-driver-lvm into draft-csi-driver-lvm-extension
Gerrit91
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft extension for csi-driver-lvm for migration.